-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the issue 412 ->Focus to glyphicon-search with necessary delay #455
Fixed the issue 412 ->Focus to glyphicon-search with necessary delay #455
Conversation
@clr-apache This solves the issue in #412 ,did it with minimum changes possible |
@sebbASF is it ready to be Merged into Main, or does need any further changes |
Works well for me: |
@sebbASF Great!!, should PR to merge into main then? |
@sebbASF @Imvedansh Please stop merging changes to www-site without my approval. This was a good change, but I have to weigh such changes with the eventual site upstate once a new logo is created. |
…455) (#456) Co-authored-by: Imvedansh <[email protected]> Co-authored-by: Imvedansh <[email protected]>
Do we have this rule documented somewhere? Perhaps we should add it to the README or add a |
Good idea. |
will you or shall I propose something? |
@bproffitt No direct commits were made to main branch, tested on Preview branches for reviews and feedback then later on |
I already added something to the README file |
Ah, great! Do you really think every change should have an issue? For smaller changes 'just' a Pull Request might be sufficient? |
I did not merge this change to the main site; all the activity took place in a preview branch, which was then used to create the PR #456. Which was not merged by me. I do not make any changes directly to the main branch, except for the occasional typo. |
Issue -> #412
Status -> Fixed , tested on local system
Follow ups -> #429 @sebbASF
Approach(optimized) -> Added the focus to input field as soon as button is click (for rendering delay of 50ms is given as well ), Issue fixed in minimum changes
using Bootstrap's native event system to detect when the search dropdown opens and then automatically places the cursor in the search field.
Proposed Issue -> When you want to search for something, you need to type a search text string. The search text needs to be entered in the search box that opens below the search button. But the cursor is still hovering over the search button so you cannot type into the search box.
Proposed Fix -> By clicking the search icon ,input fields auto focused .
Screen.Recording.2025-03-06.at.7.31.30.AM.mov