Convert dom.registry.Test to JUnit - #97
Open
elharo wants to merge 2 commits into
Open
Conversation
elharo
force-pushed
the
convert-registry-to-junit
branch
from
July 7, 2026 22:04
72cd8fb to
4f9580e
Compare
elharo
changed the title
elharo
force-pushed
the
convert-registry-to-junit
branch
from
July 8, 2026 11:58
4f9580e to
6ed62dc
Compare
elharo
changed the title
elharo
commented
Jul 8, 2026
| try { | ||
| registry = DOMImplementationRegistry.newInstance(); | ||
| Assertion.verify(registry != null); | ||
| assertNotNull("registry should not be null", registry); |
Contributor
Author
There was a problem hiding this comment.
The assertion message is redundant. remove it
|
|
||
| } catch (Exception e) { | ||
| e.printStackTrace(); | ||
| fail("Unexpected exception: " + e.getMessage()); |
Contributor
Author
There was a problem hiding this comment.
not need to call fail here or catch the exception. Unexpected exceptions fail the test without a catch
|
|
||
| } catch (Exception e) { | ||
| e.printStackTrace(); | ||
| fail("Unexpected exception: " + e.getMessage()); |
Contributor
Author
There was a problem hiding this comment.
not need to call fail here or catch the exception. Unexpected exceptions fail the test without a catch
elharo
force-pushed
the
convert-registry-to-junit
branch
from
July 8, 2026 18:51
6ed62dc to
2f30fe8
Compare
elharo
force-pushed
the
convert-registry-to-junit
branch
from
July 17, 2026 12:23
b0ed2aa to
0314913
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the dom.registry.Test test harness from a main()-driven to JUnit 3.