Skip to content

[YUNIKORN-3330] Run predicate checks in Required node preemption - #1106

Open
manirajv06 wants to merge 2 commits into
apache:masterfrom
manirajv06:YUNIKORN-3330
Open

[YUNIKORN-3330] Run predicate checks in Required node preemption#1106
manirajv06 wants to merge 2 commits into
apache:masterfrom
manirajv06:YUNIKORN-3330

Conversation

@manirajv06

Copy link
Copy Markdown
Contributor

Description

Run preemption predicate checks for required node preemption.

  • PreFilter checks
  • Filter Predicate Checks.
    Refactored existing predicate checks functions used for Intra queue preemption to make use of the same even for required node preemption as well
    Added new unit tests
    Modified existing test cases as well

Type of change

Please delete options that are not relevant.

  • Bug Fix
  • Improvement
  • Feature
  • Refactoring
  • Documentation

Jira issue

Jira ID : https://issues.apache.org/jira/browse/YUNIKORN-3330

  • I have created a Jira issue for this pull request.
  • The Jira ID is part of the title of this pull request.

AI Tooling

If an AI tool was used:

  • The PR includes the phrase "Generated by <tool>", where <tool> is the name of the AI tool used.
  • My use of AI contributions follows the ASF legal policy.

Check https://www.apache.org/legal/generative-tooling.html for details.

How has this been tested?

  • New unit tests were added to cover new or changed code paths.
  • make test_all was run, and no failures reported.
  • A pull request will be opened for new e2e tests (apache/yunikorn-k8shim repository).

Questions:

  • The change needs documentation, a pull request for apache/yunikorn-site repository will be created.
  • There is breaking changes for older versions: jira is tagged with release-notes label.
  • The licenses files needs to be updated.

Screenshots or other details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant