[YUNIKORN-3060] Update golangci-lint installation url in Coding Guide…#515
Closed
kousei47747 wants to merge 2 commits into
Closed
[YUNIKORN-3060] Update golangci-lint installation url in Coding Guide…#515kousei47747 wants to merge 2 commits into
kousei47747 wants to merge 2 commits into
Conversation
wilfred-s
requested changes
Apr 16, 2025
Contributor
wilfred-s
left a comment
wilfred-s
left a comment
There was a problem hiding this comment.
I think we need to go further with the updates. This section is completely out of date.
We do not use --new or --new-from-rev anymore as the lint issues have been fixed.
We also now automatically install the linter, the correct version for go used and the branch, in the tools directory when running make lint
Author
|
@wilfred-s good catch, thanks! I’ll update it to match the current setup with |
Author
|
I've updated the PR, please let me know if i missed something! |
github-actions Bot
pushed a commit
that referenced
this pull request
May 9, 2025
…n Coding Guidelines (#515)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
golangci-lint has changed its local installation url to here. We should update our docs accordingly.
What type of PR is it?
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-3060