Skip to content

[ZEPPELIN-3271] add shiro setup for cron feature in docs#4922

Merged
Reamer merged 1 commit into
apache:masterfrom
sh1nj1:docs/enhance-cron-scheduler
Jun 3, 2025
Merged

[ZEPPELIN-3271] add shiro setup for cron feature in docs#4922
Reamer merged 1 commit into
apache:masterfrom
sh1nj1:docs/enhance-cron-scheduler

Conversation

@sh1nj1

@sh1nj1 sh1nj1 commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

What is this PR for?

This PR adds description of another condition to enable Cron feature in documentation.
It is hard to know that is is required to configure Shiro authentication to enable Cron feature.

What type of PR is it?

Documentation

Todos

What is the Jira issue?

How should this be tested?

  • bundle exec jekyll serve --watch and check the documentation updated.

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@Reamer Reamer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right.

public boolean isZeppelinNotebookCronEnable() {
return getBoolean(ConfVars.ZEPPELIN_NOTEBOOK_CRON_ENABLE) && isAuthenticationEnabled();
}

@Reamer Reamer self-assigned this May 22, 2025
@Reamer Reamer merged commit a656888 into apache:master Jun 3, 2025
14 of 16 checks passed
asf-gitbox-commits pushed a commit that referenced this pull request Jun 3, 2025
### What is this PR for?

This PR adds description of another condition to enable Cron feature in documentation.
It is hard to know that is is required to configure Shiro authentication to enable Cron feature.

### What type of PR is it?

Documentation

### Todos

### What is the Jira issue?

* [ZEPPELIN-3271]

### How should this be tested?

* `bundle exec jekyll serve --watch` and check the documentation updated.

### Screenshots (if appropriate)

### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Closes #4922 from sh1nj1/docs/enhance-cron-scheduler.

Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
(cherry picked from commit a656888)
Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
@Reamer

Reamer commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

Merged into branch-0.12 and master.

@sh1nj1 sh1nj1 deleted the docs/enhance-cron-scheduler branch June 5, 2025 16:42
ParkGyeongTae pushed a commit to ParkGyeongTae/zeppelin that referenced this pull request Jun 6, 2025
### What is this PR for?

This PR adds description of another condition to enable Cron feature in documentation.
It is hard to know that is is required to configure Shiro authentication to enable Cron feature.

### What type of PR is it?

Documentation

### Todos

### What is the Jira issue?

* [ZEPPELIN-3271]

### How should this be tested?

* `bundle exec jekyll serve --watch` and check the documentation updated.

### Screenshots (if appropriate)

### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


Closes apache#4922 from sh1nj1/docs/enhance-cron-scheduler.

Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants