[ZEPPELIN-6262] Refactor ElasticsearchClientTypeBuilder for safer enum handling and blank input support#5002
Merged
Merged
Conversation
…m handling and blank input support
Reamer
requested changes
Jul 28, 2025
Reamer
left a comment
Reamer
left a comment
Contributor
There was a problem hiding this comment.
It looks better than the previous code, but I still have a few comments.
…ck in client type parsing
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jul 29, 2025
…m handling and blank input support ### What is this PR for? This PR refactors the ElasticsearchClientTypeBuilder class to improve its robustness and readability: - Replaces StringUtils.isEmpty() with StringUtils.isBlank() to treat whitespace-only strings as invalid input - Simplifies enum parsing by removing redundant checks and using a try-catch block around Enum.valueOf(...) - Ensures that invalid or null inputs gracefully fall back to ElasticsearchClientType.UNKNOWN ### What type of PR is it? Refactoring ### Todos * [x] - Verify existing tests ### What is the Jira issue? * Jira: https://issues.apache.org/jira/browse/ZEPPELIN-6262 ### How should this be tested? N/A ### Screenshots (if appropriate) N/A ### Questions: * Does the license files need to update? No. * Is there breaking changes for older versions? No. * Does this needs documentation? No. Closes #5002 from ParkGyeongTae/ZEPPELIN-6262. Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com> (cherry picked from commit 7c08a82) Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
Contributor
|
Merged into master and branch-0.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR refactors the ElasticsearchClientTypeBuilder class to improve its robustness and readability:
What type of PR is it?
Refactoring
Todos
What is the Jira issue?
How should this be tested?
N/A
Screenshots (if appropriate)
N/A
Questions: