[ZEPPELIN-6263] Refactor startZeppelin() into modular helper methods for clarity and maintainability#5004
Closed
ParkGyeongTae wants to merge 1 commit into
Closed
[ZEPPELIN-6263] Refactor startZeppelin() into modular helper methods for clarity and maintainability#5004ParkGyeongTae wants to merge 1 commit into
ParkGyeongTae wants to merge 1 commit into
Conversation
…for better readability and maintainability
Contributor
|
What do you think about making the private methods static as well? |
Member
Author
|
@Reamer Regarding the call order clarity — I believe improving method naming or grouping related calls (e.g., in startZeppelin()) would be a better way to make the flow more understandable, rather than relying on static modifiers. Let me know what you think! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR refactors the startZeppelin() method in ZeppelinServer by extracting its core logic into well-named modular helper methods such as initJettyHandler(), initServiceLocator(), bindZeppelinServices(), etc.
The purpose of this change is to improve readability, facilitate future maintenance, and allow better unit testing of individual steps in the startup process.
No functional behavior has been changed.
What type of PR is it?
Refactoring
Todos
What is the Jira issue?
How should this be tested?
N/A
Screenshots (if appropriate)
N/A
Questions: