[ZEPPELIN-6267] Refactor JarHelper Class to Use a Logging Framework Instead of System.out.println()#5009
Merged
Merged
Conversation
Reamer
requested changes
Aug 4, 2025
Reamer
left a comment
Reamer
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just a potentially incorrect import.
Reamer
approved these changes
Aug 8, 2025
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Aug 8, 2025
…nstead of System.out.println() ### What is this PR for? Refactor JarHelper Class to Use a Logging Framework Instead of `System.out.println()` ### What type of PR is it? Refactoring ### Todos * [x] - Replace `println()` to `LOGGER.info()` ### What is the Jira issue? * [here](https://issues.apache.org/jira/browse/ZEPPELIN-6267) ### How should this be tested? * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? - no * Is there breaking changes for older versions? - no * Does this needs documentation? - no Closes #5009 from hyunw9/ZEPPELIN-6267. Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com> (cherry picked from commit d4072a6) Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Refactor JarHelper Class to Use a Logging Framework Instead of
System.out.println()What type of PR is it?
Refactoring
Todos
println()toLOGGER.info()What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: