[ZEPPELIN-6268] Fix resource leaks and add null checks for getResourceAsStream#5010
[ZEPPELIN-6268] Fix resource leaks and add null checks for getResourceAsStream#5010renechoi wants to merge 1 commit into
Conversation
Reamer
left a comment
Reamer
left a comment
There was a problem hiding this comment.
As you can see, I am a big fan of try-with-resources.
This is a JDK8 feature and should be used because it saves a lot of boilerplate code.
| fis.read(read); | ||
| fis.close(); | ||
| assertTrue(BufferUtils.equalIncreasingByteArray(size, read)); | ||
| try { |
There was a problem hiding this comment.
Please use try-with-resources. This is more elegant.
https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
| String dstFileName) throws IOException { | ||
| FileOutputStream out = null; | ||
| InputStream in = null; | ||
| try { |
There was a problem hiding this comment.
Please use try-with-resources, also here
| @@ -134,6 +134,9 @@ private void setupJVMGateway(String gatewayHost, int gatewayPort) throws IOExcep | |||
| private void initPythonInterpreter(String gatewayHost, int gatewayPort) throws IOException { | |||
| InputStream input = | |||
There was a problem hiding this comment.
Here, closing the input stream is missing; this can be done directly with try-with-resource.
| @@ -145,6 +148,9 @@ private void initPythonInterpreter(String gatewayHost, int gatewayPort) throws I | |||
|
|
|||
| input = | |||
There was a problem hiding this comment.
Here, closing the input stream is missing; this can be done directly with try-with-resource.
| @@ -161,6 +167,9 @@ private void initPythonInterpreter(String gatewayHost, int gatewayPort) throws I | |||
|
|
|||
| if (additionalPythonInitFile != null) { | |||
| input = getClass().getClassLoader().getResourceAsStream(additionalPythonInitFile); | |||
There was a problem hiding this comment.
Here, closing the input stream is missing; this can be done directly with try-with-resource.
| @@ -129,6 +129,9 @@ protected void initIRKernel() throws IOException, InterpreterException { | |||
| String timeout = getProperty("spark.r.backendConnectionTimeout", "6000"); | |||
| InputStream input = | |||
There was a problem hiding this comment.
Same please use try-with-resource do close the stream.
| @@ -97,6 +97,9 @@ public void open() throws IOException, InterpreterException { | |||
| try { | |||
There was a problem hiding this comment.
Same use try-with-resource for the input and FileOutputStream
2 participants
What is this PR for?
This PR fixes resource management issues throughout the Zeppelin codebase, specifically addressing resource leaks and potential NullPointerExceptions.
What type of PR is it?
Bug Fix / Improvement
What is the Jira issue?
(Please create a JIRA issue if needed)
How should this be tested?
Screenshots (if appropriate)
N/A
Questions:
Changes Made:
1. AlluxioInterpreterTest.java
2. Resource Loading Null Checks
Added null checks for
getResourceAsStream()calls in:Benefits:
Testing Notes:
While I couldn't run all tests due to environment setup issues, all files compile successfully and the changes are minimal and safe - they only add defensive programming practices without changing any business logic.