[ZEPPELIN-6255] added message in the create-repository-modal for user not to be confused.#5011
Merged
Merged
Conversation
added 2 commits
August 4, 2025 23:08
…g a repository with an existing ID will update the existing repository
hyunw9
reviewed
Aug 4, 2025
hyunw9
left a comment
hyunw9
left a comment
Contributor
There was a problem hiding this comment.
Could you please refine the PR description to make it easier for the reviewer to understand the changes?
| .env | ||
| yarn.lock No newline at end of file | ||
| yarn.lock | ||
| .env.local No newline at end of file |
Contributor
There was a problem hiding this comment.
i think you intended this not to upload this .env.local file, but it was uploaded. could you fix it ?
jongyoul
reviewed
Aug 5, 2025
Member
There was a problem hiding this comment.
Please remove this configuration file.
jongyoul
reviewed
Aug 5, 2025
|
|
||
| function httpUrlToWSUrl(url) { | ||
| return url.replace(/(http)(s)?\:\/\//, "ws$2://"); | ||
| return url.replace(/(http)(s)?\:\/\//, 'ws$2://'); |
Contributor
Author
There was a problem hiding this comment.
yes, would it be a problem?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g a repository with an existing ID will update the existing repository
What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
However, this behavior is not intuitive, and users may not realize that modifying an existing repository is possible in this way.
To improve clarity, we’ve added a simple explanation to the Interpreter page UI, informing users that creating a repository with an existing ID will update the existing configuration rather than creating a new one.
Alternatively, in the future, it may be worth considering implementing a dedicated Edit Repository feature, along with an option to Remove Repository, to make this workflow even clearer.
What type of PR is it?
Bug Fix
Improvement
Feature
Documentation
Hot Fix
Refactoring
Please leave your type of PR only
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: