[ZEPPELIN-6233] Upgrade Node.js version 18#5016
Closed
celinayk wants to merge 3 commits into
Closed
Conversation
| ], | ||
| "exclude": [ | ||
| "**/node_modules/**", | ||
| "**/node_modules/**" |
Member
There was a problem hiding this comment.
Is there a reason for including **/node_modules/** twice in the exclude list? It seems redundant—one entry should be sufficient.
Contributor
Author
There was a problem hiding this comment.
Thank you for catching that! I've removed the duplicate entries from all projects in the angular.json file.
tbonelee
requested changes
Aug 15, 2025
tbonelee
left a comment
tbonelee
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the update! Unfortunately, there's a dependency version issue (see attached), so we'll need to address that first.
| yarn.lock | ||
|
|
||
| # Angular cache | ||
| .angular/cache No newline at end of file |
Contributor
There was a problem hiding this comment.
Please add a new line at the end of the file.
Contributor
|
Could we also update the <node.version> property in root pom.xml? It's used to set up the Node environment in CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Upgrade Node.js version 18
What type of PR is it?
Bug Fix
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: