refactor: use opendal as a better S3 SDK #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
tisonkun
force-pushed
the
s3-to-opendal
branch
from
70b3f8d to
61bbf82
Compare
Contributor
Author
|
cc @caiq1nyu for review |
Collaborator
|
thanks for your commits. i need to do some basic research for OpenDal first |
Signed-off-by: tison <[email protected]>
Contributor
Author
Sure. Feel free to reply here for any questions. I'd push a new commit to fix build. Please trigger a new CI run. |
Contributor
Author
|
@caiq1nyu Maybe you can give another round this week? |
Collaborator
|
No issues, the S3 operation logic looks much cleaner |
caiq1nyu
approved these changes
Nov 5, 2025
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rusoto SDK is unmaintained for a while.
cc @Xuanwo if you have some time you may take a look whether the migration is correct and thus this is a showcase we can refer to.