feat:migrate to duckdb arrow for query execution #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddh-5230
changed the title
ddh-5230
changed the title
fanyang01
reviewed
Dec 27, 2024
main.go
Outdated
| log.Fatal("Failed to get DuckDB connection") | ||
| } | ||
|
|
||
| srv, err := flightsqlserver.NewSQLiteFlightSQLServer(db, duckConn) |
Contributor
There was a problem hiding this comment.
It seems this connection serves all flightsql queries. While this is a valid approach, it is not good for concurrency. You can get a new duckdb.Conn whenever needed using the following method:
conn, err := s.db.Conn(context.Background())
// error handling...
var duckConn *duckdb.Conn
err = conn.Raw(func (driverConn any) error {
duckConn = driverConn.(*duckdb.Conn)
return nil
})
...
This can be defined as a helper method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the process of converting stdsql standard results to Arrow and directly used the Arrow support provided by DuckDB.