Skip to content

fix reddis extension start func#4

Open
hilmarf wants to merge 9 commits intomainfrom
fixRedisStart
Open

fix reddis extension start func#4
hilmarf wants to merge 9 commits intomainfrom
fixRedisStart

Conversation

@hilmarf
Copy link
Member

@hilmarf hilmarf commented Nov 21, 2025

Summary

Add connection tuning knobs to Redis storage config (timeouts, retry/backoff, ping timeout, pool timeout) with sensible defaults.
On startup, use the configured dial/read/write timeouts, ping for readiness, and retry with backoff, log attempts and return a clear failure when retries are exhausted.

Motivation

  • The Redis extension could fail to start or silently ignore startup errors due to incorrect start logic.
  • Users observed startup instability when the extension was enabled; this change makes startup behavior deterministic and failures visible.

What changed

  • Corrected the Redis extension Start implementation to properly handle context, lifecycle, and returned errors.
  • Improved error propagation so the collector fails fast on extension startup errors.
  • Added/updated unit tests to cover the corrected startup behavior.
  • Minor refactors to make the start flow clearer and more testable.

Testing

  • Unit tests added to validate successful start and failure propagation.
  • Manual verification: start the collector with the Redis extension enabled and confirm it fails on invalid configs and starts on valid configs.
  • Run: go test ./... (or CI).

Compatibility / Breaking Changes

  • No behavioral breaking changes for properly configured deployments.
  • Deployments that relied on prior silent-failure behavior will now see startup errors (intended).

Documentation

  • Add or update README/docs to note that the Redis extension will now propagate startup errors (recommended to validate config).

MJarmo and others added 2 commits November 19, 2025 10:01
Signed-off-by: MJarmo <michal.jarmolkiewicz@sap.com>
@hilmarf hilmarf moved this from In review to In progress in OTel-Audit-Logging Jan 19, 2026
MJarmo and others added 5 commits January 20, 2026 10:21
Signed-off-by: MJarmo <michal.jarmolkiewicz@sap.com>
Signed-off-by: MJarmo <michal.jarmolkiewicz@sap.com>
Signed-off-by: MJarmo <michal.jarmolkiewicz@sap.com>
@hilmarf hilmarf requested a review from MJarmo January 20, 2026 14:07
hilmarf pushed a commit that referenced this pull request Feb 3, 2026
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Added configuration schemas to following components:

* carbonreceiver
* chronyreceiver
* ciscoosreceiver
* cloudflarereceiver
* cloudfoundryreceiver
* collectdreceiver
* couchdbreceiver
* datadogreceiver
* dockerstatsreceiver


Schemas were generated with
[schemagen](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/cmd/schemagen/README.md)
script.

Link to tracking issue

open-telemetry#42214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants