Improve theme#148
Open
liberaldev wants to merge 3 commits into
Open
Conversation
Apply the dark/light detection logic from apereo/cas#9025 without the toggle: read prefers-color-scheme on load and on change, then set data-bs-theme on <html> accordingly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The "support dark mode" commit (c788729) hardcoded dark colors unconditionally across the sass partials, so light mode never rendered. Keep the original pre-dark values as the default and apply the dark colors only under [data-bs-theme="dark"], so the detection script in head can switch to a faithful light theme. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the dark theme is not perfect—for example, the footer is white—and users of the light theme are also automatically switched to the dark theme.
Users whose system is in light mode should remain in light mode.