This repository was archived by the owner on Mar 29, 2024. It is now read-only.
don't implement method with do-nothing default#517
Open
hdeadman wants to merge 1 commit into
Open
Conversation
DAOs that worked in CAS 6 will silently do nothing in CAS 7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't feel too strongly about this, but I think that people upgrading from CAS 6 to CAS 7 that have any custom person attribute DAOs will be overriding the wrong method and they will silently get no results so this takes away the default implementation and forces them to implement the correct method. The API module doesn't have SLF4J as a dependency other-wise I would have logged a warning.