Make sure method return non-null values

[wimvelzeboer]

After upgrading my projects to the latest fflib-apex-common, where some methods were moved from fflib-apex-extensions to fflib-apex-common, I found that a high number of unit-tests were failing.

Then I found out that the getIdFieldValues and getStringFieldValues were suddenly also returning null values, which makes no sense. This fix will make sure these methods always return the values and omit the nulls

---

This change is 

[ImJohnMDaniel]

@wimvelzeboer, can you also please check fflib_SObjectsTest.itShouldReturnFieldValues test method. It failed in the CI run for this PR

[ImJohnMDaniel]

@wimvelzeboer, the fflib_SObjectsTest.itShouldReturnFieldValues() test method is still failing with the following error

System.AssertException: Assertion Failed                                
Class.fflib_SObjectsTest.itShouldReturnFieldValues: line 146, column 1  

Can you take a look at this please?

[daveespo]

Reviewable status: 0 of 2 files reviewed, 5 unresolved discussions (waiting on @ImJohnMDaniel, @stohn777, and @wimvelzeboer)

a discussion (no related file):
Due to the changes in behavior that this PR proposes, my vote is to reject it

---

---

sfdx-source/apex-common/main/classes/fflib_SObjects.cls line 169 at r2 (raw file):

Previously, wimvelzeboer (William Velzeboer) wrote…

@ImJohnMDaniel You are right indeed! Its changed!

I'm less concerned about the breaking change that this introduces since you're asking for Id values and those should be non-null. But the risk isn't zero that it will break someone's assumption of how this method works.

---

sfdx-source/apex-common/main/classes/fflib_SObjects.cls line 188 at r4 (raw file):

		for (SObject record : getRecords())
		{
			if (String.isBlank((String) record.get(field)))

I don't know if I agree with this change -- Blank strings and null are distinct values for a String field. The Apex doc comment nor does the method name make it clear that values consisting of whitespace only will be excluded.

This change is definitely a breaking change and not worth the risk, IMO.