Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for Issue 221 #449

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

bugfix for Issue 221 #449

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5bc74ad
fix from @dsurfleet
jprichter Apr 28, 2023
b9288bd
unit test for registerDirty with relationship to new sObject
jprichter Apr 29, 2023
8c59274
fix: add unit test to cover update bug
ClayChipps Apr 3, 2024
32a23f4
fix: remove all changes
ClayChipps Apr 3, 2024
937d444
fix: add additional resolve logic
ClayChipps Apr 3, 2024
c72db7b
Merge branch 'master' into bugfix/issue-221
ClayChipps Apr 3, 2024
c06bde8
fix: remove null check
ClayChipps Apr 3, 2024
2e95e52
fix: remove resolved relationships
ClayChipps Apr 4, 2024
032777b
fix: revert to use previous IDML
ClayChipps Apr 4, 2024
8e8af54
Merge branch 'master' into bugfix/issue-221
ClayChipps Apr 4, 2024
fb866b2
fix: prevent null pointer on dmlInsert test
ClayChipps Apr 4, 2024
6ab9b1c
Merge branch 'master' into bugfix/issue-221
ClayChipps Apr 4, 2024
6dcecda
Merge branch 'master' into bugfix/issue-221
ImJohnMDaniel Aug 6, 2024
f6d4f7a
Merge branch 'master' into bugfix/issue-221
ImJohnMDaniel Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sfdx-source/apex-common/main/classes/fflib_SObjectUnitOfWork.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,6 +702,7 @@ public virtual class fflib_SObjectUnitOfWork
{
for (Schema.SObjectType sObjectType : m_sObjectTypes)
{
m_relationships.get(sObjectType.getDescribe().getName()).resolve();
m_dml.dmlUpdate(m_dirtyMapByType.get(sObjectType.getDescribe().getName()).values());
}
}
Expand Down Expand Up @@ -897,7 +898,9 @@ public virtual class fflib_SObjectUnitOfWork

public void resolve()
{
this.Record.put( this.RelatedToField, this.RelatedTo.Id);
if (this.Record.get(this.RelatedToField) == null){
this.Record.put( this.RelatedToField, this.RelatedTo.Id);
}
}
}

Expand Down