Prevent cloning generator when instanciating previous_data #2990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
requested changes
Aug 19, 2019
teohhanhui
reviewed
Aug 19, 2019
nitneuk
force-pushed
the
fix-previous_data
branch
5 times, most recently
from
76e042b to
f640dab
Compare
nitneuk
force-pushed
the
fix-previous_data
branch
from
f640dab to
51997f6
Compare
dunglas
approved these changes
Aug 19, 2019
|
Thanks @Nitneuk2 |
|
Shouldn't the |
|
good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a clone trait with a method
clonethat returns a clone of the given variable if cloneable.Inspired by @alanpoulain from #2978