refactor(metadata): no default graphql operation name #5348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Jan 20, 2023
| @@ -78,6 +78,7 @@ public function getItemQueryFields(string $resourceClass, Operation $operation, | |||
| return []; | |||
| } | |||
|
|
|||
| // TODO: it'd be nice to get rid of this hard coded name | |||
There was a problem hiding this comment.
Why not using instanceof here?
alanpoulain
reviewed
Jan 20, 2023
|
|
||
| if (!$useWrappedType) { | ||
| $wrappedOperationName = $operation instanceof Query ? $operationName : 'item_query'; | ||
| $wrappedOperation = $resourceMetadataCollection->getGraphQlOperation(null, forceCollection: $operation instanceof Query); |
There was a problem hiding this comment.
Why using a named argument here and not elsewhere?
There was a problem hiding this comment.
I want to start using them I can revert for the codestyle
There was a problem hiding this comment.
Personally I think it's better like this indeed. But you should uniformize the call.
alanpoulain
reviewed
Jan 20, 2023
| ->withClass($type->getClassName()) | ||
| ->withShortName($operation?->getShortName() ?? (new \ReflectionClass($type->getClassName()))->getShortName()) | ||
| ->withDescription($operation?->getDescription()); | ||
| $enumOperation = new Query(name: 'item_query', class: $type->getClassName(), shortName: $operation?->getShortName() ?? (new \ReflectionClass($type->getClassName()))->getShortName(), description: $operation?->getDescription()); |
There was a problem hiding this comment.
name is not necessary, isn't it?
alanpoulain
reviewed
Jan 20, 2023
| @@ -115,7 +115,7 @@ class: $class, | |||
| fetchPartial: $fetchPartial, | |||
| forceEager: $forceEager, | |||
| priority: $priority, | |||
| name: $name ?: 'item_query', | |||
| name: $name, | |||
There was a problem hiding this comment.
because we want to remove logic from our operations
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This is done in #5657 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.