Skip to content

(WIP)chore: Refactor HTTPRoute and HTTPRoutePolicy tests condition assertion #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release-v2-dev
Choose a base branch
from

Conversation

dspo
Copy link
Contributor

@dspo dspo commented May 16, 2025

Replace sleep-based waits with Eventually polling for condition checks, introduce helper functions for resource creation, and update test cases to use new assertion methods. This improves test stability and readability while maintaining the original test coverage.

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

dspo added 2 commits May 16, 2025 16:02
…ility

Replace sleep-based waits with Eventually polling for condition checks,
introduce helper functions for resource creation, and update test cases
to use new assertion methods. This improves test stability and readability
while maintaining the original test coverage.
Add the standard Apache License 2.0 header to the `assertion.go` file to ensure proper licensing and compliance with the project's legal requirements. This change aligns the file with the project's licensing standards.
Copy link

github-actions bot commented May 16, 2025

conformance test report

apiVersion: gateway.networking.k8s.io/v1
date: "2025-05-16T09:38:16Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
  contact: null
  organization: APISIX
  project: apisix-ingress-controller
  url: https://github.com/apache/apisix-ingress-controller.git
  version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
    result: partial
    skippedTests:
    - GatewaySecretInvalidReferenceGrant
    - GatewaySecretMissingReferenceGrant
    - HTTPRouteHTTPSListener
    - HTTPRouteInvalidCrossNamespaceBackendRef
    - HTTPRouteInvalidReferenceGrant
    - HTTPRoutePartiallyInvalidViaInvalidReferenceGrant
    - HTTPRouteReferenceGrant
    statistics:
      Failed: 0
      Passed: 26
      Skipped: 7
  name: GATEWAY-HTTP
  summary: Core tests partially succeeded with 7 test skips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant