Support draft 04 schemas#708
Open
JaredCE wants to merge 16 commits into
Open
Conversation
jeremyfiel
reviewed
Oct 13, 2025
| name: { type: 'string' }, | ||
| tag: { type: 'string' } | ||
| }, | ||
| type: [null, 'null'] |
There was a problem hiding this comment.
Suggested change
| type: [null, 'null'] |
duplicate
Author
There was a problem hiding this comment.
You're right, but i think this is fine as part of the test as i noted above
| type: 'array', | ||
| maxItems: 100, | ||
| items: { | ||
| typess: ['object', 'null'], |
There was a problem hiding this comment.
Suggested change
| typess: ['object', 'null'], | |
| type: ['object', 'null'], |
Author
There was a problem hiding this comment.
@jeremyfiel the point of this test is to skip and output a log for schemas that are invalid, so typess is valid for this test
There was a problem hiding this comment.
The problem is JSON Schema expects implementations ignores unknown keywords, the validator should not fail when it encounters the keyword.
Author
|
@thim81 all tests should be passing now |
Collaborator
|
hi @JaredCE Would it be possible to update the PR with the latest changes, afterwards we can do a final review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ajv dropped support for Draft-04 schemas, but they're still widely used.
You can use the https://github.com/ajv-validator/ajv-draft-04 package to validate v4 schemas, however you have to use that one specifically for v4 schemas. So I have split out the test for validating schemas into whether it has a
$schemaproperty of "http://json-schema.org/draft-04/schema#" and using the correct Ajv for whichever schema.$schema is a valid property of OpenAPI 3.1.X schemas.