Security/safe chain #710
Open
Security/safe chain #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements to the project's CI workflows and utilities. The main focus is on enhancing security and reliability by pinning GitHub Actions to specific commit SHAs, adding a new workflow for dependency security scanning, and improving test coverage for path-matching utilities.
CI/CD Workflow Security and Improvements:
All GitHub Actions in workflow files (
build.yml,codeql-analysis.yml,lint.yml,tests.yml) are now pinned to specific commit SHAs instead of floating version tags. This increases security by preventing supply chain attacks via compromised action versions. [1] [2] [3] [4] [5] [6]Added a new
safe-chain.ymlworkflow that runs on pull requests to scan the full dependency tree for vulnerabilities using the@aikidosec/safe-chaintool, further strengthening the project's security posture.Test and Utility Enhancements:
Improved the
pathToRegExputility to correctly handle multiple OpenAPI-style parameters in paths, and updated its implementation to replace all occurrences of{and}.Added and expanded test cases for both
pathToRegExpandmatchPathutilities to ensure correct matching of paths with single, multiple, and nested OpenAPI-style parameters. [1] [2]