move tslib to dependencies#727
Open
nicklloyd wants to merge 1 commit into
Open
Conversation
tsconfig.json has importHelpers: true, so emitted code requires tslib at runtime. Previously it was only in devDependencies, meaning consumers installing the package would hit "Cannot find module 'tslib'".
|
@thim81 Any chance of this being looked at? This is causing failures for many people it seems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsconfig.jsonsetsimportHelpers: true, so emitted code doesrequire("tslib")at runtime (61 files indist/currently).tslibwas only listed indevDependencies, so consumers installing@apideck/portmanwould fail withCannot find module 'tslib'.tslibinto runtimedependenciesand updates the lockfile.Options considered
importHelpers+ leave tslib out — simpler deps, largerdist/(each file inlines its own helpers).targettoes2019(Node 12+ supports it, matchesengines) — eliminates most helpers entirely, but it's a broader change that could surface other issues and is outside the scope of this fix.Test plan
npm run buildsucceedsdist/**/*.jsfiles resolvetslibfrom runtime deps