Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic boilerplate for 4-turbo #33

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Conversation

foxt451
Copy link
Contributor

@foxt451 foxt451 commented Dec 20, 2023

Related to #32

@foxt451
Copy link
Contributor Author

foxt451 commented Dec 20, 2023

So, I've added the same boilerplate for gpt-4-turbo as for other models, but during testing it always times out. It's not related to the page content size. I've noticed that if you comment out function calls (and e.g. add response_format: "json") it works just fine (regarding time). Also, if e.g. timeout: 10000 is added, it will always do it correctly on the third retry. I guess the problem might be langchain (there are some issues open about this model)? I'll be looking into this, but maybe @Patai5 you know something about it?

@Patai5
Copy link
Contributor

Patai5 commented Dec 26, 2023

@foxt451 That's weird, I'm testing the model currently and I'm having zero issues with it 🤷‍♂️ I guess they either fixed it since, or there might be a problem with your API key?

It's taking very long to answer compared to other models, but I guess that is the price of 128k tokens :D
Also the answer time is dependent on the content size - small content takes about 15 seconds for me, meanwhile using the full content size takes over a full minute to answer 😢

Regarding the timeout you mentioned - it looks like langchain defaults to forever :D I guess we should set something there, how about 180 seconds?

@foxt451 foxt451 changed the title [DRAFT] feat: basic boilerplate for 4-turbo feat: basic boilerplate for 4-turbo Dec 29, 2023
@foxt451 foxt451 requested a review from Patai5 December 29, 2023 12:43
@foxt451
Copy link
Contributor Author

foxt451 commented Dec 29, 2023

@Patai5 wow, have just rerun this and it worked fine this time. I guess merge then? (I've requested your review this time). Btw this model enables many capabilities like image/file sending, audio stuff, that could be added in other PRs. Especially to send images from the website

@metalwarrior665
Copy link
Contributor

I resolved the conflicts, hope I didn't screw anything :D

@metalwarrior665 metalwarrior665 merged commit 4fe385f into master Jan 3, 2024
1 check failed
@Patai5
Copy link
Contributor

Patai5 commented Jan 4, 2024

Oops, my bad, sorry, I've somehow managed to lose this PR somewhere 😅
Please ping if that happens again :P

@Patai5 Patai5 deleted the feat/gpt-4-turbo branch January 4, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants