Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: copy functionality from website content crawler #40

Merged
merged 4 commits into from
Jan 2, 2024
Merged

feat: copy functionality from website content crawler #40

merged 4 commits into from
Jan 2, 2024

Conversation

Patai5
Copy link
Contributor

@Patai5 Patai5 commented Dec 28, 2023

Added:

  • exclude URL globs
  • initial cookies
  • remove elements css selector

Had some troubles with the implementation of 'Expand clickable elements'

  • it's not very well implemented even in wcc...

Didn't implement 'HTML transformers'

  • quite complex, I will do it in a separate PR, needs some more testing

@Patai5 Patai5 changed the title Feat copy functionality from wcc feat: copy functionality from website content crawler Dec 28, 2023
metalwarrior665
metalwarrior665 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@metalwarrior665 metalwarrior665 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@metalwarrior665 metalwarrior665 merged commit 0061aee into master Jan 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalwarrior665 metalwarrior665 metalwarrior665 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Patai5 @metalwarrior665