feat: add stringy number zod schema - #16
Open
Patai5 wants to merge 2 commits into
Open
Conversation
Patai5
added this pull request to stack #17
September 11, 2026 13:55
JuanGalilea
reviewed
Sep 11, 2026
| * This validates the string is a plain non-negative integer and converts it to a `number`. | ||
| * - Also rejects values that would lose precision past `Number.MAX_SAFE_INTEGER` | ||
| */ | ||
| export const StringyNumberSchema = z |
Contributor
There was a problem hiding this comment.
maybe worth renaming to StringyIntegerSchema
| ctx.addIssue({ | ||
| code: 'custom', | ||
| message: | ||
| `Invalid input: stringy number "${value}" exceeds Number.MAX_SAFE_INTEGER and would lose precision` + |
Contributor
There was a problem hiding this comment.
did you ever encounter this in the wild?????
Author
There was a problem hiding this comment.
Yeah, but in the opposite way, where this error prevents bugs - TikTok uses really long stringy numbers as IDs, so you can get 123456789123456789123456789123456789 as an ID, and you want to keep that as a string to not corrupt your data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useful for parsing stringy numbers - "123"