refactor: rename safePushData to pushDataWithSchemaRepair - #6
Merged
Conversation
…thSchemaRepair Rename the exported function, its option/result types, the source and test files, and every doc/log/comment mention so the name says what the wrapper actually does: push, and repair against the dataset schema. - safePushData -> pushDataWithSchemaRepair - SafePushDataResult -> PushDataWithSchemaRepairResult - SafePushDataOptions -> PushDataWithSchemaRepairOptions - src/safePushData.ts -> src/pushDataWithSchemaRepair.ts - test/safePushData.test.ts -> test/pushDataWithSchemaRepair.test.ts Log-line prefixes change with the name, and the tests asserting on them were updated to match. Historical CHANGELOG entries are left as-is. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012iFDPXYxFwFGUe4PEwSAj7
yaroslav-tykhovetskyi-apify
added a commit
that referenced
this pull request
Jul 27, 2026
Resolves conflicts from master's safePushData -> pushDataWithSchemaRepair rename (#6): our vitest-ported test file and CHANGELOG unreleased section adjusted to match. Also drops gteam-internal from the README's project structure diagram (its docs already moved to src/gteam-internal/README.md).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename the main export and all related types from
safePushDatatopushDataWithSchemaRepairfor better clarity and consistency across the codebase.Changes
safePushData()→pushDataWithSchemaRepair()SafePushDataResult→PushDataWithSchemaRepairResultSafePushDataOptions→PushDataWithSchemaRepairOptionssrc/safePushData.ts→src/pushDataWithSchemaRepair.tstest/safePushData.test.ts→test/pushDataWithSchemaRepair.test.tsindex.tsto export the renamed function and typesImplementation Details
pushDataWithSchemaRepairinstead ofsafePushDataNotes
DroppedItem,ValidationError,PushFn, andisSchemaValidationErrorkeep their names — they are not specific to the renamed function.CHANGELOG.mdentries still saysafePushData; they record commits that shipped under the old name and were left untouched.https://claude.ai/code/session_012iFDPXYxFwFGUe4PEwSAj7