fix(gteam-internal): make safePushData options mutually exclusive - #7
Merged
yaroslav-tykhovetskyi-apify merged 1 commit intoJul 27, 2026
Conversation
…ally exclusive Adds explicit never fields to each overload so passing both alias and eventName together is a type error instead of a silent runtime choice. Also fixes pre-existing CHANGELOG.md formatting that was failing prettier --check. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Review feedback on PR #5 (pullrequestreview-4787394810) pointed out that safePushData's alias and eventName options were only kept apart by which overload a caller happened to pick, not by the type system. A caller passing a pre-typed options object with both fields set would slip past the overloads undetected.
What?
Each overload now marks the other option as never, so passing alias and eventName together is a compile-time error instead of a silent runtime choice.
Further notes
Also fixed a pre-existing CHANGELOG.md formatting issue that was failing prettier --check on master.