Skip to content

feat: surface approval URL when calling unapproved Actor#1111

Open
raethlo wants to merge 4 commits intomasterfrom
feat/approval-required-error
Open

feat: surface approval URL when calling unapproved Actor#1111
raethlo wants to merge 4 commits intomasterfrom
feat/approval-required-error

Conversation

@raethlo
Copy link
Copy Markdown

@raethlo raethlo commented Apr 30, 2026

tldr; the run Actor API returns an approvalUrl when an Actor needs full account access — we were swallowing it and only printing the bare error message.

Before

Run: Calling Actor apify/puppeteer-scraper (YJCnS9qogi9XxDgLB)

Error: This Actor requires full access to your account. You must approve its permissions before running it.

After

image

Handled in the same catch block as record-not-found in run-on-cloud.ts. Affects apify call, apify actors call, apify actors start, apify task run and apify tasks run.

Test plan

  • Manually triggered against apify/puppeteer-scraper, approval URL surfaces correctly
  • Add a vitest case for the full-permission-actor-not-approved branch

@raethlo raethlo marked this pull request as ready for review May 4, 2026 08:15
@raethlo raethlo requested a review from vladfrangu as a code owner May 4, 2026 08:15
@raethlo
Copy link
Copy Markdown
Author

raethlo commented May 4, 2026

@vladfrangu I am not sure about the tests, Claude generated and heavily mocked 🤷🏻 there don't seem to be any other lib tests, so I think we could just remove them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants