chore: migrate from biome to oxfmt#1123
Open
B4nan wants to merge 2 commits intochore/migrate-to-oxlintfrom
Open
chore: migrate from biome to oxfmt#1123B4nan wants to merge 2 commits intochore/migrate-to-oxlintfrom
B4nan wants to merge 2 commits intochore/migrate-to-oxlintfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces Biome (formatter) with oxfmt, matching the toolchain in apify-storage-local-js, apify-shared-js, apify-client-js, apify-core, and crawlee. Stacked on #1122 (eslint→oxlint migration); will be retargeted to
masteronce that lands.Commits
chore: add oxfmt tooling— addsoxfmt@0.46.0devDep,.oxfmtrc.json(printWidth 120, quoteProps preserve, the rest comes from.editorconfig), addsquote_type = singleto.editorconfigso oxfmt picks up biome's previous quote style; drops@biomejs/biomeandprettier(biome was the only consumer of prettier on this repo besides the markdown/yaml check, which we drop too — matches what other repos did when migrating). Swapsformat/format:checkand lint-staged to oxfmt.chore: apply oxfmt formatting— pureoxfmt --writereformat across 39 files. Diff is mostly tab/quote/line-wrap normalization that biome and oxfmt disagreed on.What changed (config side)
@biomejs/biome,prettieroxfmt@0.46.0biome.jsonwith.oxfmtrc.jsonquote_type = singleto.editorconfig(oxfmt reads it; biome had it inline)format→oxfmt --check,format:fix→oxfmtlint-stagedrunsoxfmt+oxlint --fixfor code; markdown/yaml no longer auto-formatted (consistent with the other oxfmt'd repos)Format output
Test plan
pnpm lint— cleanpnpm format— cleanpnpm build— TypeScript + tsdown both succeedFollow-up
Once this lands, add the
chore: apply oxfmt formattingcommit SHA to a.git-blame-ignore-revsfile so blame skips it.