fix: prevent path traversal by sanitizing URLs - #1011
Merged
Conversation
github-actions
Bot
added
t-tooling
Contributor
|
✅ The link checker did not find any broken links. See more at https://github.com/apify/apify-client-js/actions/runs/32943298846#summary-98098621858 |
barjin
marked this pull request as ready for review
August 26, 2026 07:35
barjin
requested review from
janbuchar and
vdusek
and removed request for
szaganek
August 26, 2026 07:37
Member
|
Yeah, let's retarget. If this only popped during internal audits and nobody is waiting for the fix, it's better to stay safe. |
janbuchar
approved these changes
Aug 26, 2026
janbuchar
left a comment
janbuchar
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me code-wise.
vdusek
requested changes
Aug 27, 2026
vdusek
left a comment
vdusek
left a comment
Contributor
There was a problem hiding this comment.
Requesting changes for retarget to v3
Contributor
|
See more at https://github.com/apify/apify-client-js/actions/runs/33059036205#summary-98472930707 |
barjin
commented
Aug 27, 2026
| } | ||
|
|
||
| // @public | ||
| export class ArgumentValidationError extends Error { |
Member
Author
There was a problem hiding this comment.
These changes are from the previous commits to v3, the checks were just failing without them.
vdusek
pushed a commit
that referenced
this pull request
Sep 8, 2026
Swaps string interpolation in URL building for sanitized composition. Related to apify/apify-client-python#1025 Closes #1005
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps string interpolation in URL building for sanitized composition.
Related to apify/apify-client-python#1025
Closes #1005