perf!: serialize requests once in batchAddRequests - #1051
Open
vdusek wants to merge 6 commits into
Open
Conversation
Contributor
|
See more at https://github.com/apify/apify-client-js/actions/runs/34350259605#summary-102461507918 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
batchAddRequestsstringified every request twice: once insliceArrayByByteLengthto measure the batch, and again in theserializeRequestinterceptor when sending. Axios then ran its defaulttransformRequeston top, becausetransformRequest: undefinedin the instance config falls back to the defaults, and that default validates a JSON string body by parsing it in full. Each batch body was stringified twice and parsed once more.content-type: application/json. The interceptor passes a string body with an explicit content type through untouched, and the axios instance setstransformRequestandtransformResponseto[]. That also removes the validation re-parse for every JSON body the client sends.Issue
batchAddRequests#972Breaking changes
setRecordwithcontentType: 'application/json'and a non-JSON string) is sent as it is. Axios used to double-encode it into a JSON string literal._batchAddRequestsand_batchAddRequestsWithRetriestake the serialized entries, and_batchAddRequestsno longer re-validates a batch the public method already validated. The API report is updated.✍️ Drafted by Claude Code