feat: allowed signature to be passed in kv-store/datasets - #761
Merged
Conversation
gippy
added
adhoc
github-actions
Bot
added
the
tested
valekjo
approved these changes
Oct 3, 2025
valekjo
left a comment
valekjo
left a comment
Member
There was a problem hiding this comment.
Looks good 👍 There are some lint errors in tests.
danpoletaev
approved these changes
Oct 6, 2025
danpoletaev
left a comment
danpoletaev
left a comment
Contributor
There was a problem hiding this comment.
Looks good for me 👍
Thank you 🙏
Following endpoints might have signature (you covered all of them):
/v2/key-value-stores/:storeId/keys/v2/key-value-stores/:storeId/records/:recordKey/v2/datasets/:datasetId/items
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with output schema in UI I found that we do not allow passing signature in client to read data from storages. This PR does not fully resolve it, but it resolves most of the issues I found.
I will leave the rest to Daniil, since he might now better which endpoints use signatures and which do not.