feat: added output schema docs - #1976
Conversation
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Generally, it looks good. I added few comments, and here are some general comments:
|
TC-MO
left a comment
There was a problem hiding this comment.
Made adjustments for clarity & style guide compliance. I also had an idea regarding structure, and perhaps it would be good to move Example section just before Advanced Examples? I know that this is different than other schema docs, but I think it makes sense to first introduce the concept, explain it, and then show example, instead of bombarding the user with example without any context
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
1 similar comment
|
Preview for this PR was built for commit |
|
Yup, thank you, I think this works much better, I'll open separate issue to reorder other schema pages in similar way. |
|
LGTM |
|
Preview for this PR was built for commit |
Resolves: https://github.com/apify/apify-core/issues/22480
This PR adds output schema docs. I have added a few examples, but there is probably even more things that can be done with it. Will try to think of more later.