fix: Align Node floor to 22 and drop dead smithery.yaml - #1210
Merged
Conversation
manifest.json advertised >=20.0.0 and the stdio guard checked < 20, while package.json engines.node already required >=22.0.0. Node 20 reached EOL on 2026-04-30. Both now match engines.node. .nvmrc and the Dockerfile stay at 24 — dev/build pins, not consumer floors. smithery.yaml pointed at dist/main.js, which the build does not produce; the stdio entry is dist/stdio.js. Part of #1064.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1064.
Node floor:
manifest.jsonsaid>=20.0.0and thestdio.tsguard checked< 20, whilepackage.jsonengines.nodealready required>=22.0.0. Node 20 hit EOL 2026-04-30. Both now matchengines.node..nvmrcand the Dockerfile stay at 24 — dev/build pins, not consumer floors.smithery.yaml: pointed at
dist/main.js, which the build does not produce (stdio entry isdist/stdio.js). No workflow or script referenced it.The README Smithery badge is left in place — removing it is a distribution call, not a config fix.