refactor: Move Skyfire constants to src/payments/ (issue #643 phase 4) - #807
Merged
Conversation
…issue #643 phase 4) - New file src/payments/const.ts holds all Skyfire constants: SKYFIRE_MIN_CHARGE_USD, SKYFIRE_SELLER_ID, SKYFIRE_TOOL_INSTRUCTIONS, SKYFIRE_PAY_ID_PROPERTY_DESCRIPTION, SKYFIRE_README_CONTENT, SKYFIRE_ENABLED_TOOLS. - CALL_ACTOR_MCP_MISSING_TOOL_NAME_MSG moves to its only production consumer src/tools/core/call_actor_common.ts. - Update consumers in src/payments/skyfire.ts, src/utils/tools.ts, src/tools/core/call_actor_common.ts, and the unit/integration tests that reference these constants.
github-actions
Bot
added
t-ai
12 tasks
jirispilka
marked this pull request as ready for review
May 7, 2026 19:21
MQ37
approved these changes
May 11, 2026
…ase-4-1iWa5 # Conflicts: # src/const.ts # tests/unit/mcp.utils.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 of #643 — move Skyfire and call-actor constants out of
src/const.ts.New file
src/payments/const.tsholding the full Skyfire cluster:SKYFIRE_MIN_CHARGE_USD(private)SKYFIRE_SELLER_ID(private)SKYFIRE_TOOL_INSTRUCTIONSSKYFIRE_PAY_ID_PROPERTY_DESCRIPTIONSKYFIRE_README_CONTENTSKYFIRE_ENABLED_TOOLSThe two private constants stay private (their only references are inside the same file via template literals).
Move
CALL_ACTOR_MCP_MISSING_TOOL_NAME_MSG→src/tools/core/call_actor_common.ts(its sole production consumer; integration test import updated).Consumers updated
src/payments/skyfire.ts→ import from./const.jssrc/utils/tools.ts→ import Skyfire consts from../payments/const.jssrc/tools/core/call_actor_common.ts→ declaresCALL_ACTOR_MCP_MISSING_TOOL_NAME_MSGlocallytests/unit/tools.skyfire.test.ts→ Skyfire consts fromsrc/payments/const.jstests/unit/mcp.utils.test.ts→SKYFIRE_README_CONTENTfromsrc/payments/const.jstests/integration/suite.ts→ splits imports acrosssrc/payments/const.jsandsrc/tools/core/call_actor_common.jsSpec verification
Spec matched current code. Phase 1 already un-exported
SKYFIRE_MIN_CHARGE_USD/SKYFIRE_SELLER_ID— preserved here.Verification
npm run type-checkpassesnpm run lintpassesnpm run test:unitpasses (613 passed, 4 skipped)Related: #643
Generated by Claude Code