Skip to content

fix(bin): case sensitivity in file path handling for git operations #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metalwarrior665 merged 3 commits into from
Apr 6, 2026
Merged

fix(bin): case sensitivity in file path handling for git operations #75

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
304ebca
fix: preserve original file path case for git show in diff-changes
claude Apr 6, 2026
70526f5
refactor: move toLowerCase into classifyFileChange
claude Apr 6, 2026
b68e00e
docs: comment that isCosmeticOnlyJsonSchemaChange requires case-sensi…
claude Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions bin/diff-changes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ type FileChange =
includes: 'all-actors' | ActorConfig;
};

const classifyFileChange = (lowercaseFilePath: string, actorConfigs: ActorConfig[], commits: Commit[]): FileChange => {
const classifyFileChange = (originalFilePath: string, actorConfigs: ActorConfig[], commits: Commit[]): FileChange => {
// Lowercase for case-insensitive matching; keep original for git show (case-sensitive on Linux)
const lowercaseFilePath = originalFilePath.toLowerCase();
if (isIgnoredTopLevelFile(lowercaseFilePath)) {
return { impact: 'ignored' };
}
Expand Down Expand Up @@ -79,7 +81,8 @@ const classifyFileChange = (lowercaseFilePath: string, actorConfigs: ActorConfig
if (lowercaseFilePath.endsWith('readme.md')) {
return { impact: 'cosmetic', includes: actorConfigChanged };
}
if (lowercaseFilePath.endsWith('.json') && isCosmeticOnlyJsonSchemaChange(commits, lowercaseFilePath)) {
// originalFilePath must be used here (not lowercaseFilePath) — git show is case-sensitive on Linux
if (lowercaseFilePath.endsWith('.json') && isCosmeticOnlyJsonSchemaChange(commits, originalFilePath)) {
return { impact: 'cosmetic', includes: actorConfigChanged };
}

Expand All @@ -101,10 +104,8 @@ export const getChangedActors = ({

const actorConfigsWithoutStandalone = actorConfigs.filter(({ isStandalone }) => !isStandalone);

const lowercaseFiles = filepathsChanged.map((file) => file.toLowerCase());

for (const lowercaseFilePath of lowercaseFiles) {
const fileChange = classifyFileChange(lowercaseFilePath, actorConfigs, commits);
for (const originalFilePath of filepathsChanged) {
const fileChange = classifyFileChange(originalFilePath, actorConfigs, commits);
if (fileChange.impact === 'ignored') {
continue;
}
Expand All @@ -126,17 +127,17 @@ export const getChangedActors = ({
const actorsChanged = Array.from(actorsChangedMap.values());

// All below here is just for logging
const ignoredFilesChanged = lowercaseFiles.filter(
const ignoredFilesChanged = filepathsChanged.filter(
(file) => classifyFileChange(file, actorConfigs, commits).impact === 'ignored',
);
console.error(`[DIFF]: Ignored files (don't trigger test or build): ${ignoredFilesChanged.join(', ')}`);

const cosmeticFilesChanged = lowercaseFiles.filter(
const cosmeticFilesChanged = filepathsChanged.filter(
(file) => classifyFileChange(file, actorConfigs, commits).impact === 'cosmetic',
);
console.error(`[DIFF]: Cosmetic files (should only trigger release build): ${cosmeticFilesChanged.join(', ')}`);

const functionalFilesChanged = lowercaseFiles.filter(
const functionalFilesChanged = filepathsChanged.filter(
(file) => classifyFileChange(file, actorConfigs, commits).impact === 'functional',
);
console.error(`[DIFF]: Functional files (trigger test & release build): ${functionalFilesChanged.join(', ')}`);
Expand Down
Loading