fix: standby tests - #76
Merged
Merged
Conversation
oklinov
commented
Apr 8, 2026
oklinov
commented
Collaborator
- make the stanby task's name shorter (to be dns friendly)
- annotate standby runs right after we get response
- put task deletion in finally block
There was a problem hiding this comment.
Pull request overview
Updates the testStandbyActor helper to improve standby task naming/cleanup and to attach run-link annotations earlier in the test flow.
Changes:
- Move standby task deletion into a
finallyblock to ensure cleanup happens even on test failures. - Annotate standby runs from inside
callStandbyto surface run links closer to the point of execution. - Change standby task name/title/description generation to be shorter and more DNS-friendly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
metalwarrior665
approved these changes
Apr 10, 2026
- make the stanby task's name shorter (to be dns friendly) - annotate standby runs right after we get response - put task deletion in finally block
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
oklinov
force-pushed
the
fix/standby-tests
branch
from
April 10, 2026 10:41
9b9f00d to
f21d4de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.