fix(core): cap retries for unprocessed requests in addRequestsBatched#3765
Merged
Conversation
When the request queue permanently rejects a request (e.g. a 400 from the platform batch-add API for a malformed `userData` shape), the recursive helper kept resubmitting the unprocessed requests forever, hanging the crawler with no actionable error. Bound the recursion to a small number of consecutive no-progress attempts; once exhausted, the remaining unprocessed requests are skipped with a warning. Any progress resets the counter so transient backpressure is still retried. Closes #3764
github-actions
Bot
added
t-tooling
barjin
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
RequestProvider.addRequestsBatchedretriedunprocessedRequestsvia a recursive helper with no retry limit. When the request queue permanently rejects a request — e.g. a400from the platform batch-add API for a malformeduserDatashape — the same request kept coming back as unprocessed, so the recursion never terminated and the crawler hung forever with no actionable error.Fix
Bound the recursion to a small number of consecutive no-progress attempts (
MAX_UNPROCESSED_REQUESTS_RETRIES = 3). Once exhausted, the remaining unprocessed requests are skipped and a warning is logged pointing at the likely cause. Any progress (some requests accepted) resets the counter, so transient backpressure is still retried as before.Closes #3764