Skip to content

feat(impit-client): add cacheClients option to disable Impit client reuse#3771

Merged
barjin merged 4 commits into
masterfrom
copilot/allow-disabling-impithttpclient-cache
Jun 22, 2026
Merged

feat(impit-client): add cacheClients option to disable Impit client reuse#3771
barjin merged 4 commits into
masterfrom
copilot/allow-disabling-impithttpclient-cache

Conversation

Copilot AI commented Jun 22, 2026 •
edited by barjin
Loading

Copy link
Copy Markdown
Contributor

ImpitHttpClient always reused cached Impit instances, which might be undesirable, as described in #3769. This change introduces an explicit cache toggle so callers can opt out of client reuse.

Adds cacheClients?: boolean to ImpitHttpClient constructor options (default: true), with JSDoc on the new option.

const httpClient = new ImpitHttpClient({
  cacheClients: false,
  // other impit options...
});

Fixes #3769

Copilot AI changed the title [WIP] Add option to disable ImpitHttpClient client cache feat(impit-client): add cacheClients option to disable Impit client reuse Jun 22, 2026
Copilot AI requested a review from barjin June 22, 2026 05:33
@barjin barjin requested a review from janbuchar June 22, 2026 05:58
@barjin barjin changed the title feat(impit-client): add cacheClients option to disable Impit client reuse feat(impit-client): add cacheClients option to disable Impit client reuse Jun 22, 2026
@barjin barjin marked this pull request as ready for review June 22, 2026 06:04
@github-actions github-actions Bot added this to the 143rd sprint - Tooling team milestone Jun 22, 2026
@github-actions github-actions Bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Jun 22, 2026
janbuchar
janbuchar approved these changes Jun 22, 2026
View reviewed changes

@janbuchar janbuchar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barjin barjin merged commit af9cb8c into master Jun 22, 2026
13 of 14 checks passed
@barjin barjin deleted the copilot/allow-disabling-impithttpclient-cache branch June 22, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janbuchar janbuchar janbuchar approved these changes
+1 more reviewer
@barjin barjin barjin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@barjin barjin

Copilot code review Copilot

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Milestone

143rd sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

Allow disabling ImpitHttpClient client cache

4 participants

@janbuchar @barjin @apify-service-account