fix: fallback to HTTP/2 on HTTP3 DNS error - #255
Merged
Merged
Conversation
github-actions
Bot
added
the
t-tooling
There was a problem hiding this comment.
Pull Request Overview
This PR adds error handling for DNS client initialization in HTTP/3 record resolution, allowing the system to gracefully fallback to HTTP/2 when DNS errors occur.
- Makes DNS client optional in the H3Engine struct to handle initialization failures
- Adds graceful error handling when DNS client creation fails
- Modifies host_supports_h3 to return false when DNS client is unavailable
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes DNS client in HTTP/3 record resolution optional. If the initial connection fails with
Error, impit will returnfalsefor every call tohost_supports_h3(unless, e.g.alt-svcheader has been registered for this domain).