Skip to content

feat(node): stream request bodies - #516

Merged
barjin merged 3 commits into
masterfrom
feat/node-streaming-bodies
Aug 24, 2026
Merged

feat(node): stream request bodies#516
barjin merged 3 commits into
masterfrom
feat/node-streaming-bodies

Conversation

@barjin

@barjin barjin commented Aug 13, 2026

Copy link
Copy Markdown
Member

Streamed bodies (ReadableStream, Node streams, async iterables) are now passed to the native layer as a pull callback, so they reach the connection as they are produced instead of being buffered up front.

Stacked on #514. Related: #513

@barjin
barjin force-pushed the feat/node-streaming-bodies branch 2 times, most recently from b6f4f66 to 911cb1d Compare August 13, 2026 11:11
@barjin
barjin changed the base branch from feat/rust-streaming-bodies to feat/python-streaming-bodies August 13, 2026 11:11
@barjin
barjin force-pushed the feat/node-streaming-bodies branch 2 times, most recently from 52e919c to fcc64d9 Compare August 13, 2026 11:26
@barjin
barjin force-pushed the feat/node-streaming-bodies branch from fcc64d9 to 89dc332 Compare August 17, 2026 07:49
@barjin
barjin force-pushed the feat/node-streaming-bodies branch from 89dc332 to 51d651b Compare August 18, 2026 08:59
@barjin
barjin force-pushed the feat/node-streaming-bodies branch from 51d651b to c01316f Compare August 18, 2026 09:37
Base automatically changed from feat/python-streaming-bodies to master August 19, 2026 21:16
@barjin
barjin requested a review from Pijukatel August 19, 2026 21:16

@Pijukatel Pijukatel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you need to rebase on master and maybe add some Node tests?

Comment thread impit-node/src/lib.rs Outdated
`ReadableStream`, Node stream and async iterable bodies are handed to the
native layer as a pull callback instead of being read to completion first,
so the chunks reach the connection as they are produced. Redirects that
would have to resend such a body now throw, as the body can't be replayed.

Related: #513
@barjin
barjin force-pushed the feat/node-streaming-bodies branch from c01316f to 05fc4ef Compare August 24, 2026 08:52
@github-actions github-actions Bot added this to the 148th sprint - Tooling team milestone Aug 24, 2026
@github-actions github-actions Bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Aug 24, 2026
@barjin
barjin requested a review from Pijukatel August 24, 2026 10:23
@barjin
barjin merged commit 4fd6c31 into master Aug 24, 2026
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants