ci(node): serialize the binding-test matrix to stop tripping httpbin's rate limit - #546
Closed
barjin wants to merge 1 commit into
Closed
ci(node): serialize the binding-test matrix to stop tripping httpbin's rate limit#546barjin wants to merge 1 commit into
barjin wants to merge 1 commit into
Conversation
The binding tests all point at a single httpbin instance that rejects anything over 70 requests per second. One test run makes 190 httpbin requests over 15-30s, so at roughly 6-12 req/s per job the 17 jobs the matrix used to start at once overran the limit and the suite failed on whichever assertions happened to receive a rate-limit body - a different random set every run. max-parallel caps each matrix at one job, so at most five run concurrently.
Member
Author
|
Generated by Claude Code |
Member
Author
|
In the end, we managed to bump the self-hosted HTTPBin limits. Closing this PR, as this would only slow down the CI now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The node binding tests all hit one httpbin instance capped at 70 req/s, and the full matrix running at once overran that, so several open PRs (#542, #543, #544) are failing on random rate-limited assertions.