feat(apify): Small improvements to the run Actor action - #14
Conversation
| @@ -210,12 +216,16 @@ export default { | |||
| const defaultValue = value.prefill ?? value.default; | |||
|
|
|||
| if (defaultValue !== undefined) { | |||
There was a problem hiding this comment.
I might be wrong, but I think we have a similiar problem as we had in n8n in this PR with the prefill/default inputs, see docs.
Here the situation is a little different as the input form is dynamically generated so I would leave the prefill, but the default value might be useless as its automatically added by Apify API. What do you think @drobnikj?
There was a problem hiding this comment.
I agree, since the default values will be automatically added by the platform we don't have to show them. And I think that showing the prefill in the input props is nice QoL feature for our users.
| if (options) props[key].options = options; | ||
|
|
||
| const defaultValue = value.prefill ?? value.default; | ||
| const defaultValue = value.prefill; |
There was a problem hiding this comment.
Can we comment here why we using prefill as default value?
It could be confusing for other devs.
| @@ -210,12 +216,16 @@ export default { | |||
| const defaultValue = value.prefill ?? value.default; | |||
|
|
|||
| if (defaultValue !== undefined) { | |||
3 participants
Links to https://github.com/apify/integrations-team/issues/25.
The goal of this PR was to implement support for the new
schemaBasesdeditor in input schema. However, Pipedream doesn't offer any nested object creation or validation that can utilize this added information.Therefore I have only fixed up some small issues that I have found while investigating potential solutions.