Skip to content

feat: Add path and pull inputs, committed output to commit action#298

Open
fnesveda wants to merge 2 commits into
mainfrom
feat/add-inputs-to-commit-action
Open

feat: Add path and pull inputs, committed output to commit action#298
fnesveda wants to merge 2 commits into
mainfrom
feat/add-inputs-to-commit-action

Conversation

@fnesveda
Copy link
Copy Markdown
Member

In https://github.com/apify/store-website-content-crawler/pull/753#discussion_r3240499474, we've decided to add a few inputs and outputs to the shared commit action to enable easier usage of it.

They are:

  • path input: which files should be staged before the commit
  • pull input: whether to call git pull before the commit and with what parameters
  • committed output: true / false whether the commit actually happened, or whether there were no changes

They mirror the interface of EndBug/add-and-commit for an easier migration from that action.

@fnesveda fnesveda requested review from B4nan and barjin May 14, 2026 14:31
@fnesveda fnesveda self-assigned this May 14, 2026
@fnesveda fnesveda added the adhoc Ad-hoc unplanned task added during the sprint. label May 14, 2026
@github-actions github-actions Bot added t-management Issues with this label belong to the CTO or engineering managers. tested Temporary label used only programatically for some analytics. labels May 14, 2026
Comment thread commit/action.yml
outputs:
commit-sha:
description: 'The SHA of the created commit.'
description: 'The SHA of the created commit. Empty when `committed` is `false`.'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it would be an easy minor win over EndBug/add-and-commit if this returned the current HEAD in case committed === false.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, done.

@fnesveda fnesveda changed the title feat: Add path and pull inputs, committed output to `commit action feat: Add path and pull inputs, committed output to commit action May 14, 2026
@fnesveda fnesveda requested a review from janbuchar May 14, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-management Issues with this label belong to the CTO or engineering managers. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants