Skip to content

fixed bug in json_error_handler #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed bug in json_error_handler #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2160c66
fixed bug in json_error_handler
Celadora Jan 26, 2017
f6c128a
commented out new Error(null)
Celadora Jan 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fittings/json_error_handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ module.exports = function create(fittingDef, bagpipes) {
}

try {
//TODO: find what's throwing here...
if (context.statusCode === 500 && !fittingDef.handle500Errors) { return next(err); }
//else - from here we commit to emitting error as JSON, no matter what.

Expand All @@ -38,7 +37,8 @@ module.exports = function create(fittingDef, bagpipes) {
if (fittingDef.includeErrStack)
Object.defineProperty(err, 'stack', { enumerable: true }); // include stack property in response

delete(context.error);
//context.error = new Error(null);

next(null, JSON.stringify(err));
} catch (err2) {
log = context.request && (
Expand Down