Skip to content

Fix: Lock Symfony dependencies to compatible versions #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shailesh-google merged 3 commits into from
Jan 7, 2026
Merged

Fix: Lock Symfony dependencies to compatible versions #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80ac793
Fix: Lock Symfony dependencies to compatible versions
shailesh-google Dec 29, 2025
d4e6331
Fix: Resolve ArgumentCountError in PropertyAccessor tests
shailesh-google Jan 6, 2026
7476eb6
Fixes PHPCS
shailesh-google Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@
"php-http/message-factory": "^1.0",
"phpdocumentor/reflection-docblock": "^5.0",
"psr/http-message": "^1.0 || ^2.0",
"symfony/options-resolver": "^7.2.0",
"symfony/property-access": "^7.2.3",
"symfony/property-info": "^7.2.3",
"symfony/serializer": "^7.2.3"
"symfony/options-resolver": "^7.3.0",
"symfony/property-access": "^7.3.0",
"symfony/property-info": "^7.3.0",
"symfony/serializer": "^7.3.0"
},
"require-dev": {
"dms/phpunit-arraysubset-asserts": "^0.4.0",
Expand All @@ -46,9 +46,9 @@
"phpmetrics/phpmetrics": "^2.7",
"phpunit/phpunit": "^9.6",
"sebastian/comparator": "^4.0.5",
"symfony/cache": "^7.2.3",
"symfony/type-info": "^7.2.2",
"symfony/var-exporter": "^7.2.0",
"symfony/cache": "^7.3.0",
"symfony/type-info": "^7.3.0",
"symfony/var-exporter": "^7.3.0",
"vimeo/psalm": "^5.20"
},
"autoload": {
Expand Down
193 changes: 193 additions & 0 deletions tests/PropertyAccess/PropertyAccessorDecoratorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,4 +214,197 @@ public function exceptionsToGetOnSetValue(): array
];
}
}

/* * COMPATIBILITY OVERRIDES (PHPUnit 9+ vs Symfony 7.4+) *
*
* Note: We use `object|array` type hint because Symfony 7.4+ enforces it.
* We use `$value = null` (optional) because some tests in 7.4 don't pass the 3rd argument.
* We use `...func_get_args()` to pass exactly the arguments received to the parent.
*/

/**
* @dataProvider getValidReadPropertyPaths
*/
public function testGetValue(object|array $objectOrArray, string $path, $value = null): void
{
parent::testGetValue(...func_get_args());
}

/**
* @dataProvider getPathsWithMissingProperty
*/
public function testGetValueThrowsExceptionIfPropertyNotFound(object|array $objectOrArray, string $path): void
{
parent::testGetValueThrowsExceptionIfPropertyNotFound(...func_get_args());
}

/**
* @dataProvider getPathsWithMissingProperty
*/
public function testGetValueReturnsNullIfPropertyNotFoundAndExceptionIsDisabled(object|array $objectOrArray, string $path): void
{
parent::testGetValueReturnsNullIfPropertyNotFoundAndExceptionIsDisabled(...func_get_args());
}

/**
* @dataProvider getPathsWithMissingIndex
*/
public function testGetValueThrowsNoExceptionIfIndexNotFound(object|array $objectOrArray, string $path): void
{
parent::testGetValueThrowsNoExceptionIfIndexNotFound(...func_get_args());
}

/**
* @dataProvider getPathsWithMissingIndex
*/
public function testGetValueThrowsExceptionIfIndexNotFoundAndIndexExceptionsEnabled(object|array $objectOrArray, string $path): void
{
parent::testGetValueThrowsExceptionIfIndexNotFoundAndIndexExceptionsEnabled(...func_get_args());
}

/**
* @dataProvider getValidWritePropertyPaths
*/
public function testSetValue(object|array $objectOrArray, string $path, $value = null): void
{
parent::testSetValue(...func_get_args());
}

/**
* @dataProvider getPathsWithMissingProperty
*/
public function testSetValueThrowsExceptionIfPropertyNotFound(object|array $objectOrArray, string $path): void
{
parent::testSetValueThrowsExceptionIfPropertyNotFound(...func_get_args());
}

/**
* @dataProvider getPathsWithMissingIndex
*/
public function testSetValueThrowsNoExceptionIfIndexNotFound(object|array $objectOrArray, string $path): void
{
parent::testSetValueThrowsNoExceptionIfIndexNotFound(...func_get_args());
}

/**
* @dataProvider getPathsWithMissingIndex
*/
public function testSetValueThrowsNoExceptionIfIndexNotFoundAndIndexExceptionsEnabled(object|array $objectOrArray, string $path): void
{
parent::testSetValueThrowsNoExceptionIfIndexNotFoundAndIndexExceptionsEnabled(...func_get_args());
}

/**
* @dataProvider getValidReadPropertyPaths
*/
public function testIsReadable(object|array $objectOrArray, string $path, $value = null): void
{
parent::testIsReadable(...func_get_args());
}

/**
* @dataProvider getPathsWithMissingProperty
*/
public function testIsReadableReturnsFalseIfPropertyNotFound(object|array $objectOrArray, string $path): void
{
parent::testIsReadableReturnsFalseIfPropertyNotFound(...func_get_args());
}

/**
* @dataProvider getPathsWithMissingIndex
*/
public function testIsReadableReturnsTrueIfIndexNotFound(object|array $objectOrArray, string $path): void
{
parent::testIsReadableReturnsTrueIfIndexNotFound(...func_get_args());
}

/**
* @dataProvider getPathsWithMissingIndex
*/
public function testIsReadableReturnsFalseIfIndexNotFoundAndIndexExceptionsEnabled(object|array $objectOrArray, string $path): void
{
parent::testIsReadableReturnsFalseIfIndexNotFoundAndIndexExceptionsEnabled(...func_get_args());
}

/**
* @dataProvider getValidWritePropertyPaths
*/
public function testIsWritable(object|array $objectOrArray, string $path, $value = null): void
{
parent::testIsWritable(...func_get_args());
}

/**
* @dataProvider getPathsWithMissingProperty
*/
public function testIsWritableReturnsFalseIfPropertyNotFound(object|array $objectOrArray, string $path): void
{
parent::testIsWritableReturnsFalseIfPropertyNotFound(...func_get_args());
}

/**
* @dataProvider getPathsWithMissingIndex
*/
public function testIsWritableReturnsTrueIfIndexNotFound(object|array $objectOrArray, string $path): void
{
parent::testIsWritableReturnsTrueIfIndexNotFound(...func_get_args());
}

/**
* @dataProvider getPathsWithMissingIndex
*/
public function testIsWritableReturnsTrueIfIndexNotFoundAndIndexExceptionsEnabled(object|array $objectOrArray, string $path): void
{
parent::testIsWritableReturnsTrueIfIndexNotFoundAndIndexExceptionsEnabled(...func_get_args());
}

/**
* @dataProvider getNullSafeIndexPaths
*/
public function testNullSafeIndexWithThrowOnInvalidIndex(object|array $objectOrArray, string $path, $value = null): void
{
parent::testNullSafeIndexWithThrowOnInvalidIndex(...func_get_args());
}

/**
* @dataProvider getReferenceChainObjectsForSetValue
*/
public function testSetValueForReferenceChainIssue($object, $path, $value): void
{
parent::testSetValueForReferenceChainIssue($object, $path, $value);
}

/**
* @dataProvider getReferenceChainObjectsForIsWritable
*/
public function testIsWritableForReferenceChainIssue($object, $path, $value): void
{
parent::testIsWritableForReferenceChainIssue($object, $path, $value);
}

/* * PHP 8.4 SKIPS * */

public function testIsWritableWithAsymmetricVisibility(): void
{
if (PHP_VERSION_ID < 80400) {
$this->markTestSkipped('Requires PHP 8.4');
}
parent::testIsWritableWithAsymmetricVisibility();
}

public function testIsReadableWithAsymmetricVisibility(): void
{
if (PHP_VERSION_ID < 80400) {
$this->markTestSkipped('Requires PHP 8.4');
}
parent::testIsReadableWithAsymmetricVisibility();
}

public function testSetValueWithAsymmetricVisibility(string $propertyPath = '', ?string $expectedException = null): void
{
if (PHP_VERSION_ID < 80400) {
$this->markTestSkipped('Requires PHP 8.4');
}
parent::testSetValueWithAsymmetricVisibility($propertyPath, $expectedException);
}
}
Loading