Skip to content

Conversation

@Fatima-Tahir
Copy link
Contributor

Description

What?

Implement Search for courses on A plus front pages - index and Archive

Why?

[ANSWER HERE]

How?

[ANSWER HERE]

Fixes #
#579

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@ihalaij1 ihalaij1 self-assigned this Jul 9, 2025
@ihalaij1 ihalaij1 moved this to Under review in A+ sprints Jul 9, 2025
@ihalaij1 ihalaij1 requested a review from Copilot October 10, 2025 09:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a search functionality for courses on A+ front pages, allowing users to search for courses by name on both the index page (showing ongoing courses) and the archive page. The search is performed using a query parameter and filters courses based on case-insensitive name matching.

  • Adds search form with input field and clear functionality to course pages
  • Implements backend filtering logic to handle course name search queries
  • Adds translation support for search-related UI text

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
locale/en/LC_MESSAGES/django.po Adds translation entry for search placeholder text
course/views.py Implements search query filtering in both IndexView and ArchiveView
course/templates/course/index.html Integrates search form into the ongoing courses section
course/templates/course/archive.html Adds search form and no results message to archive page
course/templates/course/_search_courses_form.html Creates reusable search form template with input field and clear button
course/static/course/course_search.js Provides JavaScript functionality for clearing search input

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ihalaij1 ihalaij1 marked this pull request as ready for review October 14, 2025 11:36
@ihalaij1 ihalaij1 self-requested a review October 14, 2025 11:36
Copy link
Contributor

@ihalaij1 ihalaij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

I made some fixes and improvements to the UI.

@ihalaij1 ihalaij1 merged commit 749639b into apluslms:master Oct 14, 2025
8 of 9 checks passed
@github-project-automation github-project-automation bot moved this from Under review to Done in A+ sprints Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants