Skip to content

do not overwrite own AbortSignal if an external AbortSignal is passed in - #12650

Merged
jerelmiller merged 7 commits into
release-4.0from
lenz/pr/abortcontroller-tracking
Aug 6, 2025
Merged

do not overwrite own AbortSignal if an external AbortSignal is passed in#12650
jerelmiller merged 7 commits into
release-4.0from
lenz/pr/abortcontroller-tracking

Conversation

@phryneas

Copy link
Copy Markdown
Member

This still needs tests so I'll keep it as draft for now.
I just wanted to put this in so I don't forget about it.

@changeset-bot

changeset-bot Bot commented May 28, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 94fea7d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented May 28, 2025

Copy link
Copy Markdown
npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client@12650

commit: 94fea7d

@github-actions

github-actions Bot commented May 28, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (CJS) 42.85 KB (+0.23% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) (CJS) 37.76 KB (+0.26% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" 32.82 KB (+0.19% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) 27.01 KB (+0.27% 🔺)
import { ApolloProvider } from "@apollo/client/react" 5.9 KB (0%)
import { ApolloProvider } from "@apollo/client/react" (production) 971 B (0%)
import { useQuery } from "@apollo/client/react" 7.21 KB (0%)
import { useQuery } from "@apollo/client/react" (production) 2.23 KB (0%)
import { useLazyQuery } from "@apollo/client/react" 7.1 KB (0%)
import { useLazyQuery } from "@apollo/client/react" (production) 2.13 KB (0%)
import { useMutation } from "@apollo/client/react" 6.45 KB (0%)
import { useMutation } from "@apollo/client/react" (production) 1.48 KB (0%)
import { useSubscription } from "@apollo/client/react" 6.77 KB (0%)
import { useSubscription } from "@apollo/client/react" (production) 1.79 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react" 8.58 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react" (production) 3.63 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react" 8.33 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react" (production) 3.38 KB (0%)
import { useLoadableQuery } from "@apollo/client/react" 8.28 KB (0%)
import { useLoadableQuery } from "@apollo/client/react" (production) 3.36 KB (0%)
import { useReadQuery } from "@apollo/client/react" 6.59 KB (0%)
import { useReadQuery } from "@apollo/client/react" (production) 1.63 KB (0%)
import { useFragment } from "@apollo/client/react" 6.65 KB (0%)
import { useFragment } from "@apollo/client/react" (production) 1.69 KB (0%)

@phryneas
phryneas force-pushed the lenz/pr/abortcontroller-tracking branch from 2537c96 to 054ffa7 Compare August 6, 2025 16:00
@apollo-librarian

apollo-librarian Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch release-4.0 is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

  • !docs set-base-branch version-2.6
  • !docs set-base-branch main

Build ID: 93707950b3ee8a0b3a76ea8d
Build Logs: View logs

@phryneas
phryneas marked this pull request as ready for review August 6, 2025 17:27
@phryneas
phryneas requested a review from jerelmiller August 6, 2025 17:27

@jerelmiller jerelmiller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Comment thread src/link/http/__tests__/HttpLink.ts Outdated
@jerelmiller
jerelmiller merged commit 2a32ac6 into release-4.0 Aug 6, 2025
44 checks passed
@jerelmiller
jerelmiller deleted the lenz/pr/abortcontroller-tracking branch August 6, 2025 18:13
@github-actions github-actions Bot mentioned this pull request Aug 6, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants